Added a new operator (~=) to compare strings. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you should be able to do this: "Louis-Ferdinand Céline" ~= "louis ferdinand celine" // true By default it returns true if the strings are 40% different or less. This value can be adjusted by changing the tolerance variable in the operator definition. I also added an example to the sample app, but I commented it out so as to not interfere with the regular example.
|
Hi @danielbmarques, thanks for this contribution. Even if this custom operator makes perfect sense, I am not very comfortable with the idea of imposing its existence to the extension users. I'm open to discussion, if you are aware of a way to have it optional in projects, please tell me. |
|
No problem then. I just added it for myself and thought I'd share. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you should be able to do this:
"Louis-Ferdinand Céline" ~= "louis ferdinand celine" // true
By default it returns true if the strings are 40% different or less.
This value can be adjusted by changing the tolerance variable in the
operator definition.
I also added an example to the sample app, but I commented it out so as
to not interfere with the regular example.